[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897676#comment-17897676
]
ASF subversion and git services commented on SOLR-17256:
--------------------------------------------------------
Commit 139351a89674f2fa90767c83599b86b4d935df1e in solr's branch
refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=139351a8967 ]
SOLR-17256: Nuke SolrRequest set/getBasePath in 10 (#2852)
Previous commits removed all usage of these methods, but held off on
actually removing the deprecated methods themselves. This commit now
takes the final step of doing that removal.
Should not be backported to branch_9x, as the deprecated methods are
required to remain there for the remainder of the 9.x release line.
> Remove SolrRequest.getBasePath setBasePath
> ------------------------------------------
>
> Key: SOLR-17256
> URL: https://issues.apache.org/jira/browse/SOLR-17256
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: David Smiley
> Assignee: Jason Gerlowski
> Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> SolrRequest has a getBasePath & setBasePath. The naming is poor; it's the
> URL base to the Solr node like "http://localhost:8983/solr";. It's only
> recognized by HttpSolrClient; LBSolrClient (used by CloudSolrClient) ignores
> it and will in fact mutate the passed in request to its liking, which is
> rather ugly because it means a request cannot be used concurrently if the
> user wants to. But moreover I think there's a conceptual discordance of
> placing this concept on SolrRequest given that some clients want to route
> requests to nodes *they* choose. I propose removing this from SolrRequest
> and instead adding a method specific to HttpSolrClient. Almost all existing
> usages of setBasePath immediately execute the request on an HttpSolrClient,
> so should be easy to change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
