cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1838610348
##########
solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java:
##########
@@ -115,6 +116,12 @@ public void process(ResponseBuilder rb) throws IOException
{
info.add("facet-debug", fdebug.getFacetDebugInfo());
}
+ ReverseSearchDebugInfo rsdebug =
+ (ReverseSearchDebugInfo)
(rb.req.getContext().get(ReverseSearchDebugInfo.KEY));
+ if (rsdebug != null) {
+ info.add("reverse-search-debug", rsdebug.getReverseSearchDebugInfo());
+ }
+
Review Comment:
If `DebugComponent.java` had a method something like this
```
protected void addCustomInfo(ResponseBuilder rb, NamedList<Object> info) {
FacetDebugInfo fdebug = (FacetDebugInfo)
(rb.req.getContext().get("FacetDebugInfo"));
if (fdebug != null) {
info.add("facet-trace", fdebug.getFacetDebugInfo());
}
fdebug = (FacetDebugInfo)
(rb.req.getContext().get("FacetDebugInfo-nonJson"));
if (fdebug != null) {
info.add("facet-debug", fdebug.getFacetDebugInfo());
}
}
```
then a `solr/modules/monitor` (or indeed any other custom plugin) could
extend the class and override the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
