malliaridis opened a new pull request, #2862: URL: https://github.com/apache/solr/pull/2862
# Description This PR updates Google error-prone to 2.31.0. # Solution In order to avoid blocking https://github.com/apache/solr/pull/2706 I have updated Google error-prone and added all new checks introduced between 2.23.0 and 2.31.0 without enabling them to `gradle/validation/error-prone.gradle`. Enabling the new rules should be handled in a separate PR as this may require further evaluation and compatibility check and would further delay https://github.com/apache/solr/pull/2706. The selected version 2.31.0 is the last version of error-prone that fully supports JDK 11, so this PR should be backwards compatible. Note that some new rules are not applicable to JDK 11 and should carefully be picked upon activation. Some of the existing rules seem to have had some changes that caused existing checks to fail. For the affected code, I decided individually wether to suppress the warning or fix the code. # Tests Some tests were affected by this update and were updated. The updates include assertions that were checking primitive data types for nullability and were therefore removed. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
