malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1840370734
##########
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##########
@@ -92,8 +92,7 @@ public void init(final NamedList<?> args) {
String algorithmString = params.get(ALGORITHM_PARAM);
Algorithm classificationAlgorithm;
try {
- if (algorithmString == null
- || Algorithm.valueOf(algorithmString.toUpperCase(Locale.ROOT)) ==
null) {
Review Comment:
With the changes from https://github.com/apache/solr/pull/2862, this should
no longer be an issue in this PR. As mentioned in the PR, further rule
evaluation is necessary to enable a few more useful rules for the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
