HoustonPutman commented on code in PR #735:
URL: https://github.com/apache/solr-operator/pull/735#discussion_r1882897916
##########
api/v1beta1/common_types.go:
##########
@@ -137,6 +137,10 @@ type PodOptions struct {
// +optional
ServiceAccountName string `json:"serviceAccountName,omitempty"`
+ // Should process namespace sharing be enabled on created pods
+ // +optional
+ ShareProcessNamespace *bool `json:"shareProcessNamespace,omitempty"`
Review Comment:
Since the default is false, this probably doesn't need to be a pointer.
pointer is only used when we want to differentiate the default value of the
variable and the default when users leave the field empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
