dsmiley commented on code in PR #2893:
URL: https://github.com/apache/solr/pull/2893#discussion_r1887907887
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1532,7 +1518,8 @@ private Long readIntervalNs(String interval) {
public static final String FETCH_FROM_LEADER = "fetchFromLeader";
// in case of TLOG replica, if leaderVersion = zero, don't do commit
- // otherwise updates from current tlog won't copied over properly to the new
tlog, leading to data
+ // otherwise updates from current tlog won't be copied over properly to the
new tlog, leading to
+ // data
// loss
// don't commit on leader version zero for PULL replicas as PULL should only
get its index
Review Comment:
reflow
##########
solr/CHANGES.txt:
##########
@@ -164,7 +164,8 @@ Dependency Upgrades
Other Changes
---------------------
-(No changes)
+* SOLR-17579: Remove unused code and other refactorings in ReplicationHandler
and tests. Removed unused public
Review Comment:
honestly, would any reader of CHANGES.txt care? I'm not questioning your
effort in this PR but ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
