dsmiley commented on code in PR #2899:
URL: https://github.com/apache/solr/pull/2899#discussion_r1889612751
##########
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java:
##########
@@ -374,8 +374,17 @@ PublicKey fetchPublicKeyFromRemote(String nodename) {
}
}
+ @Override
+ public void setup(Http2SolrClient.Builder httpClientBuilder, Http2SolrClient
client) {
+ setup(client, httpClientBuilder);
+ }
+
@Override
public void setup(Http2SolrClient client) {
+ setup(client, null);
+ }
+
+ private void setup(Http2SolrClient client, Http2SolrClient.Builder builder) {
Review Comment:
why have this separate and with different parameter order? In other words,
lets make *this* one the `@Override` with builder then client. Remove the 4
lines earlier on 377.
##########
solr/core/src/java/org/apache/solr/security/HttpClientBuilderPlugin.java:
##########
@@ -34,4 +34,8 @@ public interface HttpClientBuilderPlugin {
public SolrHttpClientBuilder getHttpClientBuilder(SolrHttpClientBuilder
builder);
public default void setup(Http2SolrClient client) {}
+
+ public default void setup(Http2SolrClient.Builder httpClientBuilder,
Http2SolrClient client) {
Review Comment:
Can you point me at such so I can appreciate the problem better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
