mlbiscoc opened a new pull request, #2916: URL: https://github.com/apache/solr/pull/2916
https://issues.apache.org/jira/browse/SOLR-17582 # Description `CLUSTERSTATUS` would aggregate and build the whole response including all collection properties into an `NamedList` before finally passing it to the response writers. With many or thousands of collections, this can use up memory. # Solution Instead of returning a `NamedList`, return a `MapWriter`. The Mapwriter will pull an `Iterator` from the documentStream and create `SolrCollectionProperiesIterator` implementing `iterator` and `override` `next()` to create and write the response in time, instead of writing the whole thing in memory. # Tests Fix appropriate tests that were using `NamedList` to `Map` because of the `MapWriter`. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
