epugh commented on code in PR #2919:
URL: https://github.com/apache/solr/pull/2919#discussion_r1892383853
##########
solr/solrj/src/java/org/apache/solr/common/MapWriter.java:
##########
@@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) {
writer.endObject();
}
- void writeMap(EntryWriter ew) throws IOException;
-
+ @Deprecated
Review Comment:
I kind of wish we always provide a bit more detail on these `@Deprecate`
tags. I like when I see a "since" as it let's me know when the code can be
deleted. I like when there is a "use X instead" comment.
I did a pass the other week around deprecated code and a lot it wasn't clear
what would trigger the deleting of it.. Or how long it had been deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
