mlbiscoc commented on PR #2902: URL: https://github.com/apache/solr/pull/2902#issuecomment-2555793583
> Correct me if I'm wrong, but had you kept the test that you had removed because hossman didn't like it (it was imperfect), a reviewer (like me but you too) would be able to see in this PR a diff against the output format to understand the impact (or lack of impact). In theory, yes you would see the difference that is happening here. But since you can't see the output, here is a basically the change to the output: Before: ``` curl 'localhost:8983/solr/admin/metrics?wt=prometheus' | grep "#" | sort # TYPE solr_metrics_core_average_request_time gauge # TYPE solr_metrics_core_average_request_time gauge # TYPE solr_metrics_core_average_searcher_warmup_time gauge # TYPE solr_metrics_core_average_searcher_warmup_time gauge # TYPE solr_metrics_core_cache gauge # TYPE solr_metrics_core_cache gauge # TYPE solr_metrics_core_highlighter_requests_total counter # TYPE solr_metrics_core_highlighter_requests_total counter # TYPE solr_metrics_core_index_size_bytes gauge # TYPE solr_metrics_core_index_size_bytes gauge # TYPE solr_metrics_core_requests_time_total counter # TYPE solr_metrics_core_requests_time_total counter # TYPE solr_metrics_core_requests_total counter # TYPE solr_metrics_core_requests_total counter # TYPE solr_metrics_core_searcher_documents gauge # TYPE solr_metrics_core_searcher_documents gauge # TYPE solr_metrics_core_tlog_total counter # TYPE solr_metrics_core_tlog_total counter # TYPE solr_metrics_core_update_handler gauge # TYPE solr_metrics_core_update_handler gauge # TYPE solr_metrics_jetty_dispatches_total counter # TYPE solr_metrics_jetty_requests_total counter # TYPE solr_metrics_jetty_response_total counter # TYPE solr_metrics_jvm_buffers gauge # TYPE solr_metrics_jvm_buffers_bytes gauge # TYPE solr_metrics_jvm_gc gauge # TYPE solr_metrics_jvm_gc_seconds gauge # TYPE solr_metrics_jvm_heap gauge # TYPE solr_metrics_jvm_memory_pools_bytes gauge # TYPE solr_metrics_jvm_threads gauge # TYPE solr_metrics_node_connections gauge # TYPE solr_metrics_node_core_root_fs_bytes gauge # TYPE solr_metrics_node_cores gauge # TYPE solr_metrics_node_requests_time_total counter # TYPE solr_metrics_node_requests_total counter # TYPE solr_metrics_node_thread_pool_total counter # TYPE solr_metrics_os gauge ``` After: ``` curl 'localhost:8983/solr/admin/metrics?wt=prometheus' | grep "#" | sort # TYPE solr_metrics_core_average_request_time gauge # TYPE solr_metrics_core_average_searcher_warmup_time gauge # TYPE solr_metrics_core_cache gauge # TYPE solr_metrics_core_highlighter_requests_total counter # TYPE solr_metrics_core_index_size_bytes gauge # TYPE solr_metrics_core_requests_time_total counter # TYPE solr_metrics_core_requests_total counter # TYPE solr_metrics_core_searcher_documents gauge # TYPE solr_metrics_core_tlog_total counter # TYPE solr_metrics_core_update_handler gauge # TYPE solr_metrics_jetty_dispatches_total counter # TYPE solr_metrics_jetty_requests_total counter # TYPE solr_metrics_jetty_response_total counter # TYPE solr_metrics_jvm_buffers gauge # TYPE solr_metrics_jvm_buffers_bytes gauge # TYPE solr_metrics_jvm_gc gauge # TYPE solr_metrics_jvm_gc_seconds gauge # TYPE solr_metrics_jvm_heap gauge # TYPE solr_metrics_jvm_memory_pools_bytes gauge # TYPE solr_metrics_jvm_threads gauge # TYPE solr_metrics_node_connections gauge # TYPE solr_metrics_node_core_root_fs_bytes gauge # TYPE solr_metrics_node_cores gauge # TYPE solr_metrics_node_requests_time_total counter # TYPE solr_metrics_node_requests_total counter # TYPE solr_metrics_node_thread_pool_total counter # TYPE solr_metrics_os gauge ``` `#` is just a comment in Prometheus but `# TYPE` is special. Some technologies with verify there are dupes while others don't. This just removes the duplicates and merged the metrics under a single `# TYPE` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
