[ 
https://issues.apache.org/jira/browse/SOLR-17608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907905#comment-17907905
 ] 

Jason Gerlowski commented on SOLR-17608:
----------------------------------------

I should've given a bit more detail in my writeup.  Jackson does offer 
'Instant' support - just not in their "core" module (which is all we currently 
use in terms of type-bindings).  So we have a choice of either writing a tiny 
bit of code, or adding a dep on one of Jackson's optional modules.

My preference would 100% be to add the dep: less for us to maintain and test.  
But I was kindof assuming the community preference would lean the other way, 
based on the ongoing efforts to modularize and slim down SolrJ, and from 
previous feedback back when I added Jackson to SolrJ.

> v1/v2 serialization should support 'Instant' 
> ---------------------------------------------
>
>                 Key: SOLR-17608
>                 URL: https://issues.apache.org/jira/browse/SOLR-17608
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers, SolrJ
>            Reporter: Jason Gerlowski
>            Priority: Minor
>
> David pointed out on a recent PR that it'd be nice if our API responses could 
> use 'java.time.Instant' objects.
> This is do-able but would require changes to the following:
> * add stub 'JsonSerializer' and 'JsonDeserializer' implementations to our 
> SolrJacksonMapper
> * add handling of 'Instant' in 'TextWriter.writeVal', and the corresponding 
> location in JavaBinCodec
> ** possible read-side changes to match those in TextWriter+JavaBinCodec? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to