mlbiscoc commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1896089926
##########
solr/core/src/java/org/apache/solr/core/CoreDescriptor.java:
##########
@@ -64,7 +63,7 @@ public class CoreDescriptor {
public static final String SOLR_CORE_PROP_PREFIX = "solr.core.";
public static final String DEFAULT_EXTERNAL_PROPERTIES_FILE =
- "conf" + File.separator + "solrcore.properties";
+ Path.of("conf/solrcore.properties").toString();
Review Comment:
I was worried about this so started reading `Path.of()`
[documentation](https://github.com/openjdk/jdk/blob/62a4544bb76aa339a8129f81d2527405a1b1e7e3/src/java.base/share/classes/java/nio/file/Path.java#L147)
and [oracle
documentation](https://docs.oracle.com/javase/tutorial/essential/io/pathOps.html#:~:text=Returns%20the%20string%20representation%20of%20the%20Path).
`Filesystems.getDefault().getPath(String)` which should return the OS path and
developers can use the standard `/` regardless. It's also a benefit of Path for
Solr to no longer have to do all these File.separator chars or OS checking...
I haven't actually tested this on something like a windows operating system
to confirm though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
