renatoh commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1909314089
##########
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##########
@@ -67,4 +70,8 @@ public SimpleOrderedMap<T> clone() {
newList.addAll(nvPairs);
return new SimpleOrderedMap<>(newList);
}
+
+ public static SimpleOrderedMap<Object> emptySimpleOrderedMap() {
Review Comment:
The method name of() is implying, at least to me, that something can be
passed in and and creates something else out of it. Like when you do
List.of("String"). Maybe empty() would be the better option. What do you thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
