dsmiley commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911878590
##########
solr/solrj-zookeeper/build.gradle:
##########
@@ -37,7 +37,7 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.httpcomponents:httpcore'
- implementation('org.apache.zookeeper:zookeeper', {
Review Comment:
Wouldn't a user pretty be looking only for only ZkClientClusterStateProvider
and even then only indirectly through SolrJ's reflection instantiation of it as
a result of passing ZK URLs to CloudSolrClient.Builder? I understand the
number of public classes in basically any module is large so there indeed
exists some interfaces of miscellaneous transitive dependencies. But in
practice, I think it's best to be conservative with class path exposure based
on typical use (subjective, I know). They can always add it if they need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
