dsmiley commented on code in PR #3027:
URL: https://github.com/apache/solr/pull/3027#discussion_r1912653422
##########
solr/core/src/java/org/apache/solr/core/PluginInfo.java:
##########
@@ -100,39 +100,23 @@ public String toString() {
}
}
+ /** From XML. */
Review Comment:
This constructor supports XML config generally; not just a specific file as
you wondered. I added it because it may not be obvious to the reader who may
be unfamiliar with `ConfigNode` but who would recognize XML `Node` type. The
other constructors are more general; can't be said to be from any particular
format. I could drop this but was trying to be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
