[
https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931579#comment-17931579
]
James Dyer commented on SOLR-17541:
-----------------------------------
I think PR #2899 has a good API improvement that would be nice to have in 10.x.
Thinking back, I think having this in would make integrating the new JDK
Client with CloudSolrClient easier, something I'd like to see accomplished.
I was wondering if the recent bug fixes to BasicAuthIntegratonTest also would
have fixed the problems I saw that prompted me to revert this.
(seemingly-unrelated test failures I could not quickly figure out)
Unfortunately I am busy with something else and I do not know when I can pick
this back up.
> LBSolrClient implementations should agree on 'getClient()' semantics
> ---------------------------------------------------------------------
>
> Key: SOLR-17541
> URL: https://issues.apache.org/jira/browse/SOLR-17541
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Affects Versions: 9.7
> Reporter: Jason Gerlowski
> Assignee: James Dyer
> Priority: Minor
> Labels: pull-request-available
> Fix For: main (10.0)
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> LBSolrClient has an abstract "getClient(String url)" method that is used to
> fetch a "Http" SolrClient appropriate for the specified URL.
> But implementations of this method differ in the client that is returned.
> LBHttpSolrClient returns a client that is already pointed at the specified
> URL and can be used without modification. But LBHttp2SolrClient returns a
> client with no URL altogether, that must be pointed at the right endpoint
> prior to use. This is a bit messy, and complicates the calling code in
> LBSolrClient quite a bit.
> We should choose one of these approaches and use it for all LBSolrClient
> implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
