David Smiley created SOLR-17688:
-----------------------------------
Summary: Http2SolrClient: add request listeners to the client, not
the request
Key: SOLR-17688
URL: https://issues.apache.org/jira/browse/SOLR-17688
Project: Solr
Issue Type: Improvement
Components: SolrJ
Reporter: David Smiley
The Http2SolrClient.Builder holds a list of {{HttpListenerFactory}}, a custom
Solr thing with a {{get}} method called per-request, returning something
extending the inner class RequestResponseListener, that in turn implements 3
Jetty client callback methods. It's cleaner/simpler to replace those custom
Solr abstractions with simply a list of Jetty {{Request.Listener}}, and that
which is registered directly on the Jetty {{HttpClient}}. This means less
tracking work for Http2SolrClient as it no longer holds the list of these
directly and arranges to call them. It also means the HttpClient can be
re-used with metrics, tracing, authentication for passing to Jetty's
ProxyServlet -- SOLR-17286. But it does change the listener lifecycle to be
per-client instead of per-request, which impacts one of our two implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
