janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1980520237
##########
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##########
@@ -226,6 +226,11 @@ public static String getZkHost(CommandLine cli) throws
Exception {
return zkHost;
}
+// zkHost = EnvUtils.getProperty("zkHost");
+// if (zkHost != null && !zkHost.isBlank()) {
+// return zkHost;
+// }
Review Comment:
This is the fix, commented out to prove failing test. The
`CLIUtils#getZkHost(cli)` util is used by many tools. Not sure if all tools
document the support for `ZK_HOST`, but the `zk cp` tool does. Reading property
`zkHost` works since `ZK_HOST` env is explicitly put into this sysProp by
EnvUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
