gerlowskija commented on code in PR #756:
URL: https://github.com/apache/solr-operator/pull/756#discussion_r1981474383
##########
controllers/solrcloud_controller_basic_auth_test.go:
##########
@@ -351,12 +351,12 @@ func expectBasicAuthConfigOnPodTemplateWithGomega(g
Gomega, solrCloud *solrv1bet
func expectPutSecurityJsonInZkCmd(g Gomega, expInitContainer
*corev1.Container) {
g.Expect(expInitContainer).To(Not(BeNil()), "Didn't find the setup-zk
InitContainer in the sts!")
- expCmd := "solr zk cp zk:/security.json /tmp/current_security.json
>/dev/null 2>&1; " +
+ expCmd := "solr zk cp zk:/security.json /tmp/current_security.json
--zk-host $ZK_HOST >/dev/null 2>&1; " +
Review Comment:
[-1] The `--zk-host` syntax is perfect for Solr 9.8, but I think this
param/flag changed somewhere in the last few Solr versions. So relying on it
in the initContainer would cause failures whenever someone was using e.g. Solr
9.6.
Luckily, the "short" version of the opt (`-z`) has stayed the same - so that
should be a safer option. Can the PR use that "short" syntax instead?
(@epugh - can you double-check me on this. According to the [version matrix
docs
here](https://github.com/apache/solr-operator/blob/main/docs/upgrade-notes.md#solr-versions),
operator 0.9.x currently aims to support >= 8.11, so ideally we'd get a syntax
that works through that range. If there's no single syntax that works for the
whole range, we could always do the old `||` trick with the minimum set of
syntaxes, e.g.
```
solr zk --zk-host $ZK_HOST <otherargs> || solr zk -zkHost $ZK_HOST
<otherargs>
```
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
