[
https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933574#comment-17933574
]
Chris M. Hostetter commented on SOLR-16305:
-------------------------------------------
{quote}The table above might've had a column to represent core.properties
persistence, but I omitted that as it seems like an implementation detail that
users are unlikely to care about. Am I missing something there?
{quote}
I would generally agree with you that {{core.properties}} persistence _should_
be an implementation detail – but at the moment our ref-guide makes many
references to that file, and describes the entire concept/functionality of
"substitutable properties in config files" around the existence & contents of
this file – so whatever approach is taken to rectify/unify the various types of
"property apis" needs to ensure that the ref-guide is updated to either remove
all references to {{core.properties}} (or mention it only in the context of
being an implementation detail) and explain the _concepts_ in a way that
doesn't say "adds to this file"
—
{quote}Quick summary of the current state-of-play:
{quote}
I would argue that one thing that isn't in your table but deserves equal
consideration is {{ADDREPLICAPROP}} – if we're going to go to the trouble to
cleanup & unify the way collection level props are tracked & stored & usable in
config file variable substitutions, we should ideally also think about
how/where replica level props are tracked & stored & ensure that they can also
be used in config file variable substitutions (such that replica props should
override collection props which should override system props)
> MODIFYCOLLECTION with 'property.*' changes can't change values used in config
> file variables (even though they can be set during collection CREATE)
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-16305
> URL: https://issues.apache.org/jira/browse/SOLR-16305
> Project: Solr
> Issue Type: Bug
> Reporter: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-16305_test.patch
>
>
> Consider a configset with a {{solrconfig.xml}} that includes a snippet like
> this...
> {code:java}
> <str name="param.check">${custom.prop:customDefVal}</str>
> {code}
> ...this {{custom.prop}} can be set when doing a {{CREATE}} command for a
> collection that uses this configset, using the {{property.*}} prefix as noted
> in the reg-guide...
> {quote}{{property.{_}name{_}={_}value{_}}}
> |Optional|Default: none|
> Set core property _name_ to {_}value{_}. See the section [Core
> Discovery|https://solr.apache.org/guide/solr/latest/configuration-guide/core-discovery.html]
> for details on supported properties and values.
> {quote}
> ...BUT....
> These values can *not* be changed by using the {{MODIFYCOLLECTION}} command,
> in spite of the ref-guide indicating that it can be used to modify custom
> {{property.*}} attributes...
> {quote}The attributes that can be modified are:
> * {{replicationFactor}}
> * {{collection.configName}}
> * {{readOnly}}
> * other custom properties that use a {{property.}} prefix
> See the [CREATE
> action|https://solr.apache.org/guide/solr/latest/deployment-guide/collection-management.html#create]
> section above for details on these attributes.
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
