dsmiley commented on code in PR #3249:
URL: https://github.com/apache/solr/pull/3249#discussion_r1986372473
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -78,28 +78,12 @@ public void init(List<String> solrUrls) throws Exception {
}
})
.collect(Collectors.toList());
+ this.urlScheme = this.configuredNodes.get(0).getProtocol();
Review Comment:
In my latest commit, I ended up populating urlScheme whenever we
successfully fetch liveNodes. I think it's more elegant and allows someone to
specify URLs that only vary by scheme (http vs https) which actually sounds
very useful. Hope you like it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
