epugh commented on code in PR #3247:
URL: https://github.com/apache/solr/pull/3247#discussion_r1987164110
##########
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##########
@@ -227,6 +250,20 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, CommandLine cli) th
new JSONWriter(arr, 2).write(report);
echo(arr.toString());
}
+
+ @Override
+ public int callTool() throws Exception {
+ if (zkHost == null) {
Review Comment:
i wonder if we should have a more generic abstraction that isn't tied to
"zkHost" for detecting if we are in solr cloud mode? Maybe an explicit
method, because I feel like we are slowly hiding zkHost more and more, and the
client may just be a solrClient configured with a solrUrl. <-- this isn't
specific to your picocli change I know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
