psalagnac commented on code in PR #3258:
URL: https://github.com/apache/solr/pull/3258#discussion_r1992083719
##########
solr/core/src/test/org/apache/solr/cli/PackageToolTest.java:
##########
@@ -94,7 +94,8 @@ private <T extends SolrRequest<? extends SolrResponse>> T
withBasicAuth(T req) {
@Test
public void testPackageTool() throws Exception {
- PackageTool tool = new PackageTool();
+ ToolRuntime runtime = new CLITestHelper.ValidatingRuntime();
Review Comment:
I've been using `BufferingRuntime` only for tests that actually check the
output of the executed tool. This test does not. Maybe it is worth to later
extend some tests to check output, this will be now easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
