dsmiley commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r1994576108
##########
solr/core/src/java/org/apache/solr/blockcache/BlockDirectory.java:
##########
@@ -289,12 +290,12 @@ String getFileCacheName(String name) throws IOException {
private long getFileModified(String name) throws IOException {
if (in instanceof FSDirectory) {
- File directory = ((FSDirectory) in).getDirectory().toFile();
- File file = new File(directory, name);
- if (!file.exists()) {
+ Path directory = ((FSDirectory) in).getDirectory();
+ Path file = directory.resolve(name);
Review Comment:
No. I like 'file' to differentiate from a 'dir'. 'path' is generic if
could be either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
