dsmiley commented on code in PR #3325:
URL: https://github.com/apache/solr/pull/3325#discussion_r2042344576


##########
solr/core/src/resources/EditableSolrConfigAttributes.json:
##########


Review Comment:
   Yup; I just looked for this string everywhere, and yeah, find files I didn't 
know about either.
   
   hmm; `enableRemoteStreaming` and `enableStreamBody shouldn't even be here... 
SOLR-14853 I forgot to remove them



##########
solr/solr-ref-guide/modules/configuration-guide/pages/requestdispatcher.adoc:
##########
@@ -69,21 +69,11 @@ A value of `-1` means MAX_INT, which is also the system 
default if omitted.
 This attribute sets a limit in kilobytes on the size of form data 
(`application/x-www-form-urlencoded`) submitted in a HTTP POST request, which 
can be used to pass request parameters that will not fit in a URL.
 A value of `-1` means MAX_INT, which is also the system default if omitted.
 
-`addHttpRequestToContext`::

Review Comment:
   It *is* documented @epugh .
   
   I'm surprised this was ever an option in the first place.  Always add it (I 
would have said)... but nowadays is redundant so don't need it at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to