[ 
https://issues.apache.org/jira/browse/SOLR-17746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945520#comment-17945520
 ] 

Chris M. Hostetter commented on SOLR-17746:
-------------------------------------------

I think this bug was introduced by the changes in SOLR-6962.

[~epugh] - can you please take a look?  I'm not sure I understand why 
34f77886104a15f9e478cf7b4a5f6b0691d79eb7 added this simple check for 
{{--jvm-options}} ...
{noformat}
+            if [[ -z "$2" ]]; then
+              print_usage "$SCRIPT_CMD" "JVM options are required when using 
the $1 option!"
{noformat}
but this more restrictive check for {{--jettyconfig}} ...
{noformat}
+            if [[ -z "$2" || "${2:0:1}" == "-" ]]; then
+              print_usage "$SCRIPT_CMD" "Jetty config is required when using 
the $1 option!"
{noformat}

> bin/solr always fails if you attempt to use --jettyconfig (aka "-j")
> --------------------------------------------------------------------
>
>                 Key: SOLR-17746
>                 URL: https://issues.apache.org/jira/browse/SOLR-17746
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Chris M. Hostetter
>            Priority: Major
>
> The "-jettyconfig" optiona (aka "-j") is documented as...
> {noformat}
>   -j <jettyParams>      Additional parameters to pass to Jetty when starting 
> Solr.
>                           For example, to add configuration folder that jetty 
> should read
>                           you could pass: -j 
> "--include-jetty-dir=/etc/jetty/custom/server/"
>                           In most cases, you should wrap the additional 
> parameters in double quotes.
> {noformat}
> ..but if you actually attempt to run  use that example option, you will get 
> an error...
> {noformat}
> ./bin/solr start ... -j "--include-jetty-dir=/etc/jetty/custom/server/"
> ERROR: Jetty config is required when using the -j option!
> {noformat}
> IIUC this is because the bash code for parsing this option requires that it 
> not start with a "{{\-}}" character; but by definition any option you want to 
> pass to jetty will start with "{{\--}}".
> Attempting to workaround this problem by using two sets of quotes doesn't 
> seem to work -- the inner quotes are passed verbatim to jetty which seems to 
> prevent jetty from recognizing it as a valid option.
> A workaround that *does* seem to work (in my limited testing) is to include a 
> leading space character _inside_ the quotes...
> {noformat}
> ./bin/solr start ... -j " --include-jetty-dir=/etc/jetty/custom/server/"
> {noformat}
> ...because for some reason that does *NOT* seem to be passed verbatim.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to