[
https://issues.apache.org/jira/browse/SOLR-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947021#comment-17947021
]
ASF subversion and git services commented on SOLR-17043:
--------------------------------------------------------
Commit 94e77be23408d2cad79e624b8672d2a488394936 in solr's branch
refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=94e77be2340 ]
SOLR-17043: Fix TestTlogReplica test
Test was using 'QueryRequest' (of type 'QUERY') to send a
rebalance-leaders API call (which needs a request of type 'ADMIN').
This was causing SolrJ to build the path incorrectly and fail.
This commit changes the test to use GenericSolrRequest, until we have a
more functional RebalanceLeadersSolrRequest
> Remove SolrClient path pattern matching
> ---------------------------------------
>
> Key: SOLR-17043
> URL: https://issues.apache.org/jira/browse/SOLR-17043
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ, v2 API
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Minor
> Labels: V2, pull-request-available
> Fix For: main (10.0)
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> Currently, some SolrClient implementations (especially our "load-balancing"
> and "cloud" clients) do pattern-matching on the path to guess the "type"
> (admin, update, etc. ) of each request. This seems unnecessary though, as
> SolrRequest already has a "getRequestType" method exposing this. We should
> use this method where possible instead of the ad-hoc pattern matching we
> currently do, which is brittle and doesn't map well to the varied paths used
> by our v2 APIs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
