[ 
https://issues.apache.org/jira/browse/SOLR-17758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950600#comment-17950600
 ] 

Rahul Goswami commented on SOLR-17758:
--------------------------------------

Thanks for creating the JIRA Jason. Although I do see that due to the reason 
you mentioned, the chain would get terminated irrespective of whether warnOnly 
is true or false, since the user complained of getting a 400 error 
(SolrException.ErrorCode.BAD_REQUEST) the real culprit here seems to be this 
'>' check in init() . It should be ">=" I believe.
https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java#L72



> NumFieldLimiting URP "warnOnly" mode broken
> -------------------------------------------
>
>                 Key: SOLR-17758
>                 URL: https://issues.apache.org/jira/browse/SOLR-17758
>             Project: Solr
>          Issue Type: Bug
>          Components: UpdateRequestProcessors
>    Affects Versions: 9.8.1
>            Reporter: Jason Gerlowski
>            Priority: Minor
>
> NumFieldLimitingUpdateProcessorFactory (introduced in SOLR-17192) aims to 
> offer a "warnOnly" mode that logs a warning when the maximum number of fields 
> is exceeded.
> But the "warnOnly" code path doesn't trigger any subsequent processors in the 
> chain.  So in effect, both modes will prevent new documents from being added 
> once the limit has been exceeded.
> We should rework this logic so that the warnOnly=true codepath allows 
> documents to be indexed as expected.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to