gerlowskija opened a new pull request, #3349: URL: https://github.com/apache/solr/pull/3349
https://issues.apache.org/jira/browse/SOLR-17761 # Description On startup, each Solr process will attempt to load each of the cores that it hosts (potentially in parallel). Each core gets its own "CircuitBreakerRegistry". And on creation, these registries attempt to initialize some static state representing any global circuit-breakers. This can lead to a race where multiple loading cores attempt to modify the same static state, resulting in a ConcurrentModificationException. # Solution Making 'globalCircuitBreakerMap' a ConcurrentHashMap ensures that multiple CircuitBreakerRegistry's won't race or trigger ConcurrentModificationException's trying to initialize the static state on startup. # Tests N/A - if anyone can think of a good way to test the potential concurrency issue here, please share! # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
