[ 
https://issues.apache.org/jira/browse/SOLR-17761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952120#comment-17952120
 ] 

ASF subversion and git services commented on SOLR-17761:
--------------------------------------------------------

Commit 68423b576cc60a5039a42e0cbd2dcb45cdf74896 in solr's branch 
refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=68423b576cc ]

SOLR-17761: Prevent CircuitBreakerRegistry static init races (#3349)

Making 'globalCircuitBreakerMap' a ConcurrentHashMap ensures that
multiple CircuitBreakerRegistry's won't race or trigger
ConcurrentModificationException's trying to initialize the static state
on startup.

> "Global" Circuit Breakers can trigger ConcurrentModificationException on Solr 
> startup
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-17761
>                 URL: https://issues.apache.org/jira/browse/SOLR-17761
>             Project: Solr
>          Issue Type: Bug
>          Components: Circuit Breakers
>    Affects Versions: main (10.0), 9.7, 9.8.1
>            Reporter: Jason Gerlowski
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> On startup, each Solr process will attempt to load each of the cores that it 
> hosts (potentially in parallel).  Each core gets its own 
> "CircuitBreakerRegistry".  And on creation, these registries attempt to 
> initialize some static state representing any global circuit-breakers.
> This can lead to a race where multiple loading cores attempt to modify the 
> same static state, resulting in a ConcurrentModificationException.
> We should either have CircuitBreakerRegistry use a ConcurrentHashMap, or put 
> some other locking in place to make the global CB state more resilient to 
> races.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to