kotman12 opened a new pull request, #3356:
URL: https://github.com/apache/solr/pull/3356

   https://issues.apache.org/jira/browse/SOLR-17711
   
   # Description
   
   There is now a default total request timeout applied to IndexFetcher because 
of Jetty Http2 client migration. We ran into a few problems with this already 
during replication of large number of shards on a single host. Sometimes we hit 
machine bandwidth limits because shards are downloaded in parallel. Thus 
requests for the next segment of each shard compete with each other and 
sometimes take more than 120 seconds. The 120 second number is important 
because it is the default _idle_ timeout and ever since [this 
change](https://github.com/apache/solr/commit/e62cb1b0066132347589b5e5ca38f38fd5e668d0),
 the idle timeout happens to be the total request timeout in the http2 client. 
I don't think that is a good idea in the case of IndexFetcher, hence this 
change.
   
   # Solution
   
   Revert to the pre-`Http2SolrClient` behavior of no timeout in `IndexFetcher`.
   
   # Tests
   
   Not aware of an easy way to test this reasonably, i.e. to accelerate the 
clock.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [X] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to