malliaridis opened a new pull request, #3358: URL: https://github.com/apache/solr/pull/3358
# Description With the `production` build flag set to `false`, gradle may fail when running `gradlew assemble` with an error due to some invalid task dependencies coming from the Compose MP plugin. The reported message is similar to the below: See also discussion in https://lists.apache.org/thread/1l25p9cd9h8ch32jt2ljpmdt3fc9bctq ``` ... > Task :solr:ui:wasmJsProductionExecutableCompileSync FAILED FAILURE: Build failed with an exception. * What went wrong: A problem was found with the configuration of task ':solr:ui:wasmJsProductionExecutableCompileSync' (type 'DefaultIncrementalSyncTask'). - Gradle detected a problem with the following location: '/Users/christos/workspace/apache/solr/build/js/packages/composeApp/kotlin'. Reason: Task ':solr:ui:wasmJsBrowserDevelopmentWebpack' uses this output of task ':solr:ui:wasmJsProductionExecutableCompileSync' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Possible solutions: 1. Declare task ':solr:ui:wasmJsProductionExecutableCompileSync' as an input of ':solr:ui:wasmJsBrowserDevelopmentWebpack'. 2. Declare an explicit dependency on ':solr:ui:wasmJsProductionExecutableCompileSync' from ':solr:ui:wasmJsBrowserDevelopmentWebpack' using Task#dependsOn. 3. Declare an explicit dependency on ':solr:ui:wasmJsProductionExecutableCompileSync' from ':solr:ui:wasmJsBrowserDevelopmentWebpack' using Task#mustRunAfter. For more information, please refer to https://docs.gradle.org/8.10/userguide/validation_problems.html#implicit_dependency in the Gradle documentation. ``` The current workaround is to set the `production` flag to `true`. # Solution This PR solves the issue of the invalid task dependencies and allows the `production` flag to be set to `false` again without failing on `gradlew assemble`. The `production` flag can be set to `false` again on our build servers after merging this. # Tests _No tests written for gradle execution_ # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
