[ 
https://issues.apache.org/jira/browse/SOLR-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jerry Chung updated SOLR-17768:
-------------------------------
    Description: 
{{    for (Map.Entry<String, Pair<Future<NamedList<Object>>, SolrClient>> entry 
:}}
{{        responses.entrySet()) {}}
{{      try {}}
{{        NamedList<Object> resp = entry.getValue().first().get(10, 
TimeUnit.SECONDS);}}
{{        entry.getValue().second().close();}}
{{        rsp.add(entry.getKey(), resp);}}
{{      } catch (ExecutionException ee) {}}
{{        log.warn("Exception when fetching result from node {}", 
entry.getKey(), ee);}}
{{      } catch (TimeoutException te) {}}
{{        log.warn("Timeout when fetching result from node {}", entry.getKey(), 
te);}}
             }
        }

 

`{{{}entry.getValue().second().close();` might not be called in case of 
errors{}}}

  was:
{{    for (Map.Entry<String, Pair<Future<NamedList<Object>>, SolrClient>> entry 
:}}
{{        responses.entrySet()) {}}
{{      try {}}
{{        NamedList<Object> resp = entry.getValue().first().get(10, 
TimeUnit.SECONDS);}}
{{        entry.getValue().second().close();}}
{{        rsp.add(entry.getKey(), resp);}}
{{      } catch (ExecutionException ee) {}}
{{        log.warn("Exception when fetching result from node {}", 
entry.getKey(), ee);}}
{{      } catch (TimeoutException te) {}}
{{        log.warn("Timeout when fetching result from node {}", entry.getKey(), 
te);}}
{{      }}}
{{    }}}

 

`{{{}entry.getValue().second().close();` might not be called in case of 
errors{}}}


> Solr client might not be closed in AdminHandlersProxy
> -----------------------------------------------------
>
>                 Key: SOLR-17768
>                 URL: https://issues.apache.org/jira/browse/SOLR-17768
>             Project: Solr
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 9.6.1
>            Reporter: Jerry Chung
>            Priority: Major
>
> {{    for (Map.Entry<String, Pair<Future<NamedList<Object>>, SolrClient>> 
> entry :}}
> {{        responses.entrySet()) {}}
> {{      try {}}
> {{        NamedList<Object> resp = entry.getValue().first().get(10, 
> TimeUnit.SECONDS);}}
> {{        entry.getValue().second().close();}}
> {{        rsp.add(entry.getKey(), resp);}}
> {{      } catch (ExecutionException ee) {}}
> {{        log.warn("Exception when fetching result from node {}", 
> entry.getKey(), ee);}}
> {{      } catch (TimeoutException te) {}}
> {{        log.warn("Timeout when fetching result from node {}", 
> entry.getKey(), te);}}
>              }
>         }
>  
> `{{{}entry.getValue().second().close();` might not be called in case of 
> errors{}}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to