rahulgoswami opened a new pull request, #3378: URL: https://github.com/apache/solr/pull/3378
https://issues.apache.org/jira/browse/SOLR-XXXXX <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Running gradlew -p solr/core test --tests "org.apache.solr.cli.TestSolrCLIRunExample" on Windows causes tests for techproducts, films and other examples to fail. # Solution Tests initiated via TestSolrCLIRunExample use a custom executor (RunExampleExecutor). The execute(cmd) method of this executor executes one logic of starting an embedded test solr cluster when the script is bin/solr and a default alternate flow otherwise. This condition should instead check for either of bin/solr or bin/solr.cmd since starting a test cluster in embedded mode essentially makes this flow platform independent. One could argue that the way we spawn a test cluster for these tests doesn't *exactly* replicate a CLI flow, but that could be tackled as a separate fix to make the tests *better*. # Tests gradlew -p solr/core test --tests "org.apache.solr.cli.TestSolrCLIRunExample" succeeds on Windows. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
