dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2096407656


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java:
##########
@@ -256,7 +256,7 @@ void sendUpdateStream() throws Exception {
             }
 
             Response response =
-                responseListener.get(client.getIdleTimeout(), 
TimeUnit.MILLISECONDS);
+                responseListener.get(client.getRequestTimeoutMillis(), 
TimeUnit.MILLISECONDS);

Review Comment:
   It was weird to be using the idle (aka socket) timeout in a situation where 
we're waiting for the request.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to