[ https://issues.apache.org/jira/browse/SOLR-17764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979332#comment-17979332 ]
Mark Robert Miller commented on SOLR-17764: ------------------------------------------- * Should code in Solr that checks for shutdown and throws a 503 _stop_ doing that so that in flight requests can finish? Its just showing your graceful shutdown is half baked. If things are closing, outstanding requests are going to randomly choke. If you want a graceful shutdown, you can't shutdown Solr until Jetty has stopped accepting new requests and allowed all in flight requests to finish. * Should CloudSolrClient retry on any 503? Yes. But graceful shutdown will still be half baked, though it may allow that test to skirt by. > "graceful" jetty shutdown causes ChaosMonkeySafeLeaderWithPullReplicasTest > failures > ----------------------------------------------------------------------------------- > > Key: SOLR-17764 > URL: https://issues.apache.org/jira/browse/SOLR-17764 > Project: Solr > Issue Type: Bug > Reporter: Chris M. Hostetter > Priority: Major > Attachments: > E7F93005B9386058.OUTPUT-org.apache.solr.cloud.ChaosMonkeySafeLeaderWithPullReplicasTest.txt > > > Reviewing recent jenkins test failure metrics, I noticed that (Nightly) test > ChaosMonkeySafeLeaderWithPullReplicasTest started failing ~60% of the time > right around the time that SOLR-17744 was committed. > Things i have observed: > * Seeds from failing runs seem to reliably reproduce the failure > ** These failures do *NOT* reproduce if i revert to just before SOLR-17744 > * Ad-hoc testing I've done of seeds that do _not_ fail on first attempt seem > to reliably succeed on all subsequent attempts > ** Suggesting that the root cause is something deterministic in the > {{{}random(){}}}-ness of the test, and not something dependent on timing or > concurrency. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org