mlbiscoc commented on PR #3384: URL: https://github.com/apache/solr/pull/3384#issuecomment-2981090664
> I think scope is intended to basically refer to all of Solr (e.g. be something like "org.apache.solr"), possibly with module consideration added (e.g. add ".llm"). Actually this makes sense. If you have a single place where many different metrics are stored, this scope name might be the differentiator especially if all your systems have some general metric like `http_requests_total`. So then all scope should be `org.apache.solr` technically. Do you still find value in keeping the concept of registry as a label on all metrics then? If not, I don't see the need to keep `SolrMetricsContext` and we should just create metrics through `SolrMetricManager` because that is currently all I am using it for. I don't see much value in aggregating on a label like `registry` except for `solr.core.*` but we have core as a label already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
