[ 
https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17982888#comment-17982888
 ] 

ASF subversion and git services commented on SOLR-17776:
--------------------------------------------------------

Commit dd89cd604a6dd563f15dfcec4f7a9ce5076b2410 in solr's branch 
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=dd89cd604a6 ]

SOLR-17776: Harmonize SolrJ timeouts (#3357)

SolrJ: If Http2SolrClient.Builder.withHttpClient is used, (and it's used more 
in 9.8, shifted from deprecated Apache HttpClient  based clients), settings 
affecting HttpClient construction cannot be customized; an 
IllegalStateException will now be thrown if you try.
The connection timeout cannot be customized, but idle & request timeouts can 
be.  Callers (various places in Solr) no longer customize the connection 
timeout.

The HttpJdkSolrClient wasn't setting the connection timeout as per the builder 
configuration.

Co-authored-by: Luke Kot-Zaniewski <lkotzanie...@bloomberg.net>


> Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
> --------------------------------------------------------------------
>
>                 Key: SOLR-17776
>                 URL: https://issues.apache.org/jira/browse/SOLR-17776
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: David Smiley
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> See the linked dev list thread.  Summary:
> If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in 
> 9.8, shifted from deprecated Apache HttpClient based clients): settings 
> affecting HttpClient construction cannot be customized; an 
> IllegalStateException will now be thrown if you try.  The connection timeout 
> cannot be customized, but idle & request timeouts can be.  Callers (various 
> places in Solr) should no longer customize the connection timeout.  
> Additionally, there's a bug wherein withHttpClient usage meant that the idle 
> & request timeouts couldn't be increased.
> The HttpJdkSolrClient wasn't setting the connection timeout as per the 
> builder configuration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to