bruno-roustant commented on code in PR #3412: URL: https://github.com/apache/solr/pull/3412#discussion_r2176828002
########## solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java: ########## Review Comment: This rollback was previously done inside CoreContainer.checkTragicException() called line 310 (was the only caller of checkTragicException). Now I need to also call checkTragicException() in DirectUpdateHandler2 to give the appropriate error code. I don't see where to put this rollback code elsewhere. Rename this method processReceivedException? Unless we put it back in checkTragicException() with an additional boolean param to trigger it (I don't like it much)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
