psalagnac commented on PR #3432: URL: https://github.com/apache/solr/pull/3432#issuecomment-3097541381
> I wonder if we could turn this into a test rule for all tests, like we do for sys props. That way no one can break tests like this in the future. That's a great suggestion. We already have `LogLevelTestRule`, but right now it only handles levels that are overridden by test code. We could add checks so the test fails in case production code does not restore logging levels. > and maybe we could fix this at the SolrCLI level I personally dislike the approach of shutting down loggers. This makes debugging of CLI tools impossible in case something goes wrong. I understand we want a clean output in the user console. Logs should not go there. Can't we have a dedicated `log4j.xml` for CLI tools? So relevant logs go to a `solr-cli.log` file or similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
