[
https://issues.apache.org/jira/browse/SOLR-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis updated SOLR-17672:
----------------------------------------
Description:
The new UI module was introduced with minimal configuration changes. As result,
some tooling has not been configured to apply on the new multiplatform module,
including spotless.
h2. Task
Enable and configure spotless to use ktlint with default configuration.
h2. Acceptance Criteria
- The UI module classes (main and test) are formatted
- Whenever spotless runs, it checks the formatting
- *.gradle.kts files are formatted
h2. Additional Information
You can find example configurations here:
https://github.com/diffplug/spotless/tree/main/plugin-gradle#kotlin
Spotless can use ktlint, and since we are using Compose too, some custom
rulesets may have to be added and adjusted via the .editorconfig. A set of
custom rules that we can use is https://mrmans0n.github.io/compose-rules/
Note that we are currently configuring spotless in
{{/gradle/validation/spotless.gradle}}.
was:
The new UI module was introduced with minimal configuration changes. As result,
some tooling has not been configured to apply on the new multiplatform module,
including spotless.
h2. Task
Enable and configure spotless to use ktlint with default configuration.
h2. Acceptance Criteria
- The UI module classes (main and test) are formatted
- Whenever spotless runs, it checks the formatting
- *.gradle.kts files are formatted
h2. Additional Information
You can find example configurations here:
https://github.com/diffplug/spotless/tree/main/plugin-gradle#kotlin
Note that we are currently configuring spotless in
{{/gradle/validation/spotless.gradle}}.
> Enable spotless in new UI
> -------------------------
>
> Key: SOLR-17672
> URL: https://issues.apache.org/jira/browse/SOLR-17672
> Project: Solr
> Issue Type: Improvement
> Components: Admin UI
> Reporter: Christos Malliaridis
> Priority: Major
> Labels: gradle, new-ui, newdev
>
> The new UI module was introduced with minimal configuration changes. As
> result, some tooling has not been configured to apply on the new
> multiplatform module, including spotless.
> h2. Task
> Enable and configure spotless to use ktlint with default configuration.
> h2. Acceptance Criteria
> - The UI module classes (main and test) are formatted
> - Whenever spotless runs, it checks the formatting
> - *.gradle.kts files are formatted
> h2. Additional Information
> You can find example configurations here:
> https://github.com/diffplug/spotless/tree/main/plugin-gradle#kotlin
> Spotless can use ktlint, and since we are using Compose too, some custom
> rulesets may have to be added and adjusted via the .editorconfig. A set of
> custom rules that we can use is https://mrmans0n.github.io/compose-rules/
> Note that we are currently configuring spotless in
> {{/gradle/validation/spotless.gradle}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
