mlbiscoc commented on code in PR #3427:
URL: https://github.com/apache/solr/pull/3427#discussion_r2226631977
##########
solr/core/src/java/org/apache/solr/response/PrometheusResponseWriter.java:
##########
@@ -55,12 +59,19 @@ public void write(
List<MetricSnapshot> snapshots =
readers.values().stream().flatMap(r -> r.collect().stream()).toList();
- new PrometheusTextFormatWriter(false).write(out,
mergeSnapshots(snapshots));
+ boolean openMetricsFormat =
"openmetrics".equals(request.getParams().get("format"));
Review Comment:
Maybe we do both then. I think I saw in the 9.9 change log that v2 apis use
`Accept` as header request if wt isn't passed in. We could follow the same
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
