[
https://issues.apache.org/jira/browse/SOLR-17834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-17834:
--------------------------------------
Attachment: SOLR-17834.hack.test.patch
Status: Open (was: Open)
Using the attached test case (which is a hack, quickly thrown together using
bits and bobs from other existing tests with a focus on being able to apply
cleanly to many versions of solr) i used git bisect to identify this as the
commit that introduced the bug...
{noformat}
dd28664ab85c7ad5c541755ff7693128594e68b1 is the first bad commit
commit dd28664ab85c7ad5c541755ff7693128594e68b1
Author: David Smiley <[email protected]>
Date: Tue Dec 10 10:52:18 2024 -0500 SOLR-14680: Deprecating
org.apache.solr.cluster.api, includes NamedList methods (#2856)
NamedList: deprecated methods: forEachEntry, forEachKey,
abortableForEachKey, abortableForEach,
asMap (no-arg only), get(key, default) -- all come from the SimpleMap
interface. Added getOrDefault.
Deprecated the SimpleMap interface as well as the entirety of the SolrJ
package org.apache.solr.cluster.api, which wasn't used except for SimpleMap.
Includes some trivial refactorings to not call those deprecated methods.
Includes internal changes to ConfigNode and friends so as to not use
SimpleMap.
(cherry picked from commit c80d41597c83c8c73634144ab8c55f8002dd101d):040000
040000 01ffc8be78461c824aa0cf51b37c88291c49c234
737f409f81c4828d85c544c715df6f4a0ccb3f2d M solr
bisect run success
{noformat}
Full bisection log...
{noformat}
# bad: [8bf0100e502ade4b8161e4b90f762b117a6ef442] SOLR-16390: fix flaky test
ClusterPropsAPITest.testClusterPropertyOpsAllGood (#2901)
# good: [ca6a71e353e753f50cbbea31861ac87e3425c0c1] SOLR-17368: Fix
TestPrometheusResponseWriter by clearing registries (#2613)
git bisect start 'releases/solr/9.8.0'
'ca6a71e353e753f50cbbea31861ac87e3425c0c1'
# good: [9ef97f95a222ee6dd24352fa428f84e008bd2913] SOLR-17480: Use --data-home
everywhere (#2747)
git bisect good 9ef97f95a222ee6dd24352fa428f84e008bd2913
# good: [2ff209a88a9ff1a9104ca4a553db4aa48b7b35c5] Update org.hamcrest:* to v3
(major) (#2845)
git bisect good 2ff209a88a9ff1a9104ca4a553db4aa48b7b35c5
# good: [f22a40eb59b9da86af2c02aded83f18949da6392] SOLR-17569: fix flaky test
TestLBHttpSolrClient (9.x) / LBHttp2SolrClientIntegrationTest (main) (#2884)
git bisect good f22a40eb59b9da86af2c02aded83f18949da6392
# bad: [532f091ecc75f79cb4707a3903a3560dddbd567d] SOLR-17561: Deprecations in
ClusterState, DocCollection, Replica (#2898)
git bisect bad 532f091ecc75f79cb4707a3903a3560dddbd567d
# good: [f492e24881c5724a1b1baecfc9549e2cb0257525] SOLR-16781: Disable <lib/>
by default on 9.x (#2894)
git bisect good f492e24881c5724a1b1baecfc9549e2cb0257525
# good: [01c6d16a63f8f625b9c936ea62ec0fd81e666805] Update Antora metadata for
pre-released minor version 9.8.0
git bisect good 01c6d16a63f8f625b9c936ea62ec0fd81e666805
# bad: [dd28664ab85c7ad5c541755ff7693128594e68b1] SOLR-14680: Deprecating
org.apache.solr.cluster.api, includes NamedList methods (#2856)
git bisect bad dd28664ab85c7ad5c541755ff7693128594e68b1
# good: [62705d7cae48a391b44d12134bd9b9070f3df960] Add dependency updates to
CHANGES for 9.8.0
git bisect good 62705d7cae48a391b44d12134bd9b9070f3df960
# first bad commit: [dd28664ab85c7ad5c541755ff7693128594e68b1] SOLR-14680:
Deprecating org.apache.solr.cluster.api, includes NamedList methods (#2856)
{noformat}
/ping [~dsmiley]
> config API 'set-user-property' no longer has affect on solrconfig.xml:
> notably update.autoCreateFields
> -------------------------------------------------------------------------------------------------------
>
> Key: SOLR-17834
> URL: https://issues.apache.org/jira/browse/SOLR-17834
> Project: Solr
> Issue Type: Bug
> Affects Versions: 9.9, 9.8
> Reporter: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-17834.hack.test.patch
>
>
> As (indirectly) discovered by tim610156 on the solr-user mailing list,
> Something broke between 9.7.0 and 9.8.0 that (evidently) causes the
> {{set-user-property}} command to no longer modify the variables resolved when
> the {{solrconfig.xml}} is re-loaded as part of the resulting core/collection
> reload.
> *MOST NOTABLY*
> This mean that our well documented instructions for disabling
> {{autoCreateFields}} no longer seems to have any effect...
> {noformat}
> hossman@slate:~$ curl -sS 'http://localhost:8983/solr/test/schema/fields' |
> grep bogus
> hossman@slate:~$ curl http://localhost:8983/solr/test/config -d
> '{"set-user-property": {"update.autoCreateFields":"false"}}'
> {
> "responseHeader":{
> "status":0,
> "QTime":245
> },
> "WARNING":"This response format is experimental. It is likely to change in
> the future."
> }hossman@slate:~$
> hossman@slate:~$ curl
> 'http://localhost:8983/solr/test/update?commitWithin=1000&overwrite=true' -H
> 'Content-type: application/json' --data
> '[{"id":"hoss","bogus_field":"bogus_value"}]'
> {
> "responseHeader":{
> "status":0,
> "QTime":191
> }
> }hossman@slate:~$
> hossman@slate:~$ curl -sS 'http://localhost:8983/solr/test/schema/fields' |
> grep bogus
> "name":"bogus_field",
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
