chatman commented on PR #3053:
URL: https://github.com/apache/solr/pull/3053#issuecomment-3156889838
The grouping implementation was only using filter queries for search
ignoring the main query entirely. This caused function queries like
{\!func}foo2_i to be ignored during grouping, resulting in all groups receiving
a score of 1.0 from MatchAllDocsQuery instead of proper function query scores.
This broke group ordering when Sort.RELEVANCE was used (the default), as
groups were not ordered by their maximum scores as expected.
The fix uses QueryUtils.combineQueryAndFilter() to properly combine the main
query (for scoring) with filter queries (for filtering), matching the behavior
of normal Solr search operations. This ensures function queries and other
scoring queries work correctly with grouping.
Hence, these are now fixed: TestFiltering, TestGroupingSearch and
TestDistributedGrouping.
Now, the tests that are remaining are:
```
org.apache.solr.analysis.PathHierarchyTokenizerFactoryTest
org.apache.solr.TestRandomDVFaceting
org.apache.solr.handler.TestSnapshotCoreBackup
org.apache.solr.search.TestComplexPhraseLeadingWildcard
org.apache.solr.schema.PreAnalyzedFieldTest
org.apache.solr.search.TestQueryLimits
org.apache.solr.uninverting.TestFieldCacheVsDocValues
org.apache.solr.uninverting.TestFieldCache
org.apache.solr.update.processor.PreAnalyzedUpdateProcessorTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
