dsmiley commented on PR #3053: URL: https://github.com/apache/solr/pull/3053#issuecomment-3165355972
I'm only "blaming" you for not following a best practice (twice now) on big/important PRs. Nothing more. If neither broke things I wouldn't be happy but probably wouldn't have said anything. It's tempting to say this was already reviewed, which is somewhat true (people looked at it and offered to help) but that's different than an explicit approval. Reviewing a change (before merge) is an industry standard best practice, and it is is such for good reason -- it leads to better quality software and reduces the chance of breaking the build (which annoys the dev community). Cleanup/fix commits are permanent annoyance (we're not going to force push a rebase of main to fix); should be minimized. CTR allows us to use our judgement on when to merge exactly, but that doesn't mean we (as professional software engineers that strive for quality software) don't agree with peer review before merging. It means we trust you to consider the factors and merge anyway if you feel its warranted. I don't think Anshum's proposed feature freeze date creates true urgency here but if you disagree then announce your plan to commit in 1 day. It's common for interested people to delay givi ng a PR a look until hearing that it's ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
