dsmiley commented on code in PR #3469:
URL: https://github.com/apache/solr/pull/3469#discussion_r2280704599
##########
solr/core/src/java/org/apache/solr/handler/component/SpellCheckComponent.java:
##########
@@ -875,17 +875,7 @@ public Map<String, SolrSpellChecker> getSpellCheckers() {
return Collections.unmodifiableMap(spellCheckers);
}
- // ///////////////////////////////////////////
- // / SolrInfoBean
- // //////////////////////////////////////////
-
- @Override
public String getDescription() {
Review Comment:
What caught my attention is that you removed the `@Override`, which we
mandate by our "precommit" checks. Thus I was led to believe
SpellCheckComponent no longer overrides this method. So I wondered why is it
staying around.
So I suspect you haven't been running precommit on all these PRs. Try
`./gradlew precommit -Pvalidation.sourcePatterns.failOnError=false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
