dsmiley commented on code in PR #3447:
URL: https://github.com/apache/solr/pull/3447#discussion_r2281036489
##########
solr/benchmark/src/java/org/apache/solr/bench/Docs.java:
##########
@@ -110,11 +110,7 @@ public Iterator<SolrInputDocument> preGenerate(int
numDocs) throws InterruptedEx
executorService.execute(() -> docs.add(Docs.this.inputDocument()));
}
- executorService.shutdown();
- boolean result = executorService.awaitTermination(10, TimeUnit.MINUTES);
- if (!result) {
- throw new RuntimeException("Timeout waiting for doc adds to finish");
- }
+ ExecutorUtil.shutdownAndAwaitTermination(executorService);
Review Comment:
technically unrelated but it caught my eye
##########
solr/benchmark/src/test/org/apache/solr/bench/MiniClusterBenchStateTest.java:
##########
Review Comment:
This test indirectly/unintentionally exercises the remote proxy
functionality. Go fig. Any way, when it fails, it wasn't cleaning up so I
made the test better formed. It doesn't fail now, BTW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
