epugh commented on code in PR #3312: URL: https://github.com/apache/solr/pull/3312#discussion_r2287907678
########## solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java: ########## @@ -32,28 +33,47 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.stream.Collectors; import org.apache.solr.common.SolrException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Provides convenient access to System Properties for Solr. It also converts 'SOLR_FOO' env vars to * system properties 'solr.foo', which is done on first access of this class. All Solr code should * use this in lieu of JDK equivalents. */ public class EnvUtils { + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + /** Maps ENV keys to sys prop keys for special/custom mappings */ private static final Map<String, String> CUSTOM_MAPPINGS = new HashMap<>(); + /** Maps deprecated sys prop keys to current sys prop keys with special/custom mappings */ + private static final Map<String, String> DEPRECATED_MAPPINGS = new HashMap<>(); + private static final Map<String, String> camelCaseToDotsMap = new ConcurrentHashMap<>(); static { try { Properties props = new Properties(); + Properties deprecatedProps = new Properties(); try (InputStream stream = - EnvUtils.class.getClassLoader().getResourceAsStream("EnvToSyspropMappings.properties")) { + EnvUtils.class + .getClassLoader() + .getResourceAsStream("EnvToSyspropMappings.properties"); + InputStream stream2 = + EnvUtils.class + .getClassLoader() + .getResourceAsStream("EnvToSyspropDeprecatedMappings.properties")) { Review Comment: Need to mull on this more! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org