dsmiley commented on PR #3423: URL: https://github.com/apache/solr/pull/3423#issuecomment-3208889968
I toyed with another constructor and with an enum of 2 options... and it just wasn't worth it IMO. At least isn't if there are all these other constructors one might call. Might as well use setRequiresCollection(true). IMO it's still sad it's forgettable to call it but I want to move on. I need to close the JIRA issue, remove it from the PR title, and I'm not sure what to say for this PR other than basically "Use better request types and HTTP methods". I've got another shelved change soon to become a PR that was going to use GenericCollectionRequest but I'll update it to use GenericSolrRequest with setRequiresCollection. That one is more interesting, changing many wrong usages of QueryRequest for non-queries (non-SearchHandler). They were using "qt", which I'm trying to reduce/remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
