epugh commented on code in PR #3504:
URL: https://github.com/apache/solr/pull/3504#discussion_r2296670737


##########
solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java:
##########
@@ -232,6 +232,14 @@ static synchronized void init(
               deprecatedKey,
               key);
           setProperty(key, String.valueOf(!Boolean.getBoolean(deprecatedKey)));
+        } else if (deprecatedKey.equals("disable.config.edit")
+            || deprecatedKey.equals("disable.v2.api")) {

Review Comment:
   I did, but it only worked with this pattern:
   
   ```
    if (key.endsWith(".enabled") && deprecatedKey.endsWith(".disabled")) {
   ```
   
   I was thinking that I would just collect up a few of these, and then later 
go back and do something fancier.   I didn't have a sense of if it would be one 
or two, or a whole set.  Tackle it in another PR however.
   
   Also, all of this get's deleted in a few months when we cut `branch_10` and 
start Solr 11!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to